-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Presubmit Go-native runner #19
Comments
Where will the binary look for the configuration? Do we want to pass the path as an argument like in #17 where the first argument is the path (i.e. Or possibly pass the configuration as an argument: |
I was thinking we can have this as an optional argument, which by default will take the information from the current module (see the modscope tool) |
This issue is stale because it has been open for 90 days with no |
/reopen |
@cardil: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Rewrite
presubmit-tests.sh
script (https://github.com/knative/hack/blob/main/README.md#using-the-presubmit-testssh-helper-script) into a Golang toolknative.dev/toolbox/presubmit
.Invent new Go-native extension interface, for example:
# will look for Go files with `presubmit` build constraints, that register configuration go run knative.dev/toolbox/presubmit@latest --unit-tests
An example configuration might look like:
The text was updated successfully, but these errors were encountered: