Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen Go-native tool #18

Open
Tracked by #254
cardil opened this issue Oct 10, 2023 · 3 comments
Open
Tracked by #254

Codegen Go-native tool #18

cardil opened this issue Oct 10, 2023 · 3 comments
Assignees
Labels
kind/enhancement triage/accepted Issues which should be fixed (post-triage)

Comments

@cardil
Copy link
Contributor

cardil commented Oct 10, 2023

Rewrite codegen-library.sh script into a Golang tool knative.dev/toolbox/codegen. The current script:

https://github.com/knative/hack/blob/158898889ae8670c7e68e522e32cd6800e1729a0/codegen-library.sh#L19-L35

Invent new CLI, for example:

go run knative.dev/toolbox/codegen@latest k8s \
  "deepcopy,client,informer,lister" \
  knative.dev/serving/pkg/client knative.dev/serving/pkg/apis \
  "serving:v1 serving:v1beta1 autoscaling:v1alpha1"

go run knative.dev/toolbox/codegen@latest knative \
  "injection" \
  knative.dev/serving/pkg/client knative.dev/serving/pkg/apis \
  "serving:v1 serving:v1beta1 autoscaling:v1alpha1"

go run knative.dev/toolbox/codegen@latest deepcopy-gen \
  -i knative.dev/serving/pkg/apis/config \
  -i knative.dev/serving/pkg/reconciler/route/config \
  -i knative.dev/serving/pkg/autoscaler/config/autoscalerconfig \
  -i knative.dev/serving/pkg/autoscaler/scaling \
  -i knative.dev/serving/pkg/deployment \
  -i knative.dev/serving/pkg/gc
@cardil cardil changed the title codegen too, Codegen Go-native tool Oct 10, 2023
@cardil cardil transferred this issue from knative/hack Oct 10, 2023
@cardil cardil self-assigned this Nov 13, 2023
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@cardil
Copy link
Contributor Author

cardil commented Apr 5, 2024

/reopen
/remove-lifecycle stale
/triage accepted

Copy link

knative-prow bot commented Apr 5, 2024

@cardil: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle stale
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot reopened this Apr 5, 2024
@knative-prow knative-prow bot added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

1 participant