Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when running pylint with pylint version >= 2.0 #367

Open
Jean-Daniel opened this issue Jul 18, 2018 · 5 comments
Open

Crash when running pylint with pylint version >= 2.0 #367

Jean-Daniel opened this issue Jul 18, 2018 · 5 comments

Comments

@Jean-Daniel
Copy link

recent pylint version don't support the exit keyword (and uses do_exit instead)

File "/opt/jenkins/workspace/webservices/env/lib/python3.6/site-packages/django_jenkins/management/commands/jenkins.py", line 116, in handle
    coverage.save(tested_locations, options)
  File "/opt/jenkins/workspace/webservices/env/lib/python3.6/site-packages/django_jenkins/tasks/run_pylint.py", line 44, in run
    lint.Run(args, reporter=ParseableTextReporter(output=output), exit=False)
TypeError: __init__() got an unexpected keyword argument 'exit'
@Jean-Daniel Jean-Daniel changed the title Crash when running pylint Crash when running pylint with pylint version >= 2.0 Jul 18, 2018
@camilonova
Copy link
Contributor

@kmmbvnr can you please take a look?

@rooterkyberian
Copy link

In the mean time I'm using following monkey patch:

from django_jenkins.tasks import run_pylint


class Lint:
    class Run(run_pylint.lint.Run):
        def __init__(self, *args, **kwargs):
            super().__init__(*args, do_exit=kwargs.pop("exit"), **kwargs)


run_pylint.lint = Lint

@sergei-maertens
Copy link

@kmmbvnr is there anything we can do to progress this PR? 😃

@HayHiTee
Copy link

HayHiTee commented Jan 2, 2020

The same problem for django-jenkins 0.110.0 and pylint 2.4.4

@sergei-maertens
Copy link

Pylint < 2.0 is also not avaible for Python 3.7, so this is really becoming a problem :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants