Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a Zimit-based article is opened in a separate tab, external links and PDFs are blocked #540

Open
Jaifroid opened this issue Jan 24, 2024 · 2 comments
Open

When a Zimit-based article is opened in a separate tab, external links and PDFs are blocked #540

Jaifroid opened this issue Jan 24, 2024 · 2 comments
Labels
bug/non-critical security Vulnerabilities or other issues affecting security upstream Should be worked on in kiwix-js zimit
Milestone
Release 3.4.0

Comments

@Jaifroid
Copy link
Member

This is no doubt because the replay_iframe which is still used in tabs for Zimit classic is sandboxed.

We can't remove the sandbox because Zimit classic archives have so many external links that can get called before wombat is fully initialized.

Let's see if this is fixed by zimit2, which no longer uses the replay_iframe.
@Jaifroid Jaifroid added bug/non-critical security Vulnerabilities or other issues affecting security zimit labels Jan 24, 2024
@Jaifroid Jaifroid added this to the Release 3.1.0 milestone Jan 24, 2024
@Jaifroid Jaifroid added the upstream Should be worked on in kiwix-js label Jan 24, 2024
@Jaifroid
Copy link
Member Author

Also affects Kiwix JS.

This was referenced Jan 24, 2024
Open
Closed
@Jaifroid
Copy link
Member Author

I'm having trouble reproducing this here now, which may be due to better link handling, or may just be that I'm not testing the right thing. Monitor.

@Jaifroid Jaifroid modified the milestones: Release 3.1.0, Release 3.2.0 Feb 2, 2024
@Jaifroid Jaifroid modified the milestones: Release 3.2.0, Release 3.3.0 Mar 25, 2024
@Jaifroid Jaifroid modified the milestones: Release 3.3.0, Release 3.4.0 Apr 23, 2024
@Jaifroid Jaifroid modified the milestones: Release 3.4.0, Release 3.3.0 May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/non-critical security Vulnerabilities or other issues affecting security upstream Should be worked on in kiwix-js zimit
Projects
None yet
Milestone
Release 3.4.0
Development

No branches or pull requests
1 participant
@Jaifroid