Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bookmark data for PDF files #827

Closed
BPerlakiH opened this issue Jun 22, 2024 · 3 comments
Closed

Improve bookmark data for PDF files #827

BPerlakiH opened this issue Jun 22, 2024 · 3 comments
Assignees
@BPerlakiH
Labels
enhancement question
Milestone
3.5.0

Comments

@BPerlakiH
Copy link
Collaborator

Following up the issue of #826
We might consider using more data from the PDF files for the purpose of creating bookmarks.
The following fields are displayed from Bookmarks:

  • title
  • (optional) short snippet
  • (optional) image url
@BPerlakiH BPerlakiH self-assigned this Jun 22, 2024
@BPerlakiH BPerlakiH linked a pull request Jun 22, 2024 that will close this issue
Improved data for bookmark creation #828
Closed
@kelson42 kelson42 added this to the 3.5.0 milestone Jun 22, 2024
@BPerlakiH BPerlakiH mentioned this issue Jun 22, 2024
Merged
@kelson42 kelson42 mentioned this issue Jun 22, 2024
Closed
@kelson42
Copy link
Contributor

At this stage my question is: Is that a good idea at all to have an image and a snippet extracted from the article? Do we really need that? Are we aware that such a requirement might a serious impact in term of code complexity to be done properly (next question would be the support of a Video file for example)?

@BPerlakiH
Copy link
Collaborator Author

@kelson42 I have created a proposition and a draft PR, to help you with this question: #830

@BPerlakiH
Copy link
Collaborator Author

I think it can be now closed, as the bookmark PR is merged.

@kelson42 kelson42 modified the milestones: 3.6.0, 3.5.0 Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BPerlakiH BPerlakiH

Labels
enhancement question
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Improved data for bookmark creation kiwix/kiwix-apple
2 participants
@kelson42 @BPerlakiH