-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZIM metadata „illustration“ is not read properly #789
Comments
Not sure how this is done, but there is a primitive in libkiwix which shiukd be used: I suspect that because the logo of the ZIM is accessed directly and because we have changed in the path the URL, then something is wrong. Please read https://wiki.openzim.org/wiki/Metadata |
The reader is using its book->getIllustrations().at(0)->url Documentation is of no help here but a quick glimpse at the code have me believe that @BPerlakiH, we should use |
Makes sense, metadata should be retrieved from online catalogue AFAP, but if no entry there, ALL metadata (illustration included) should come from the ZIM file. |
Solar Powered and Quartiers chinois still use category image in this screenshot… |
Given you use this device to test the app, I'm not sure it's a wise choice to be on a beta system… but there's no downgrade possible so it's too late now 😀 |
Yes, but see it the other way: we prefer to detect problems with iOS18 earlier, better than waiting the system is live. @rgaudin How does you iOS device behaves regarding this very specific issue? Is rhat fixed for you? |
I figured, but you're the only tester we have! Hope it works well on current stable! |
@rgaudin Thx, I wonder if there is not a cache somewhere which would make the test of the patch complicated!? |
@rgaudin can you tell me which icon is wrong ? |
The one you see top left. that's not a zim icon but the other category icon in the app. Only zim added via catalog shows their icons |
I think the same happened for @kelson42 as well, after the iOS update, the files must have been re-added to the local DB, and from then on they were fixed. |
Moving to 3.5.0 |
OK that explains it. Are we OK with this? If yes then this ticket should be closed |
Here we have a proper logo (with Kiwix Server)
https://dev.library.kiwix.org/#lang=&q=Mali+mp4
But the same file in the Kiwix local library displays the defaukt logo placeholder
The text was updated successfully, but these errors were encountered: