Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove full scanning feature #4011

Open
kelson42 opened this issue Oct 1, 2024 · 2 comments
Open

Remove full scanning feature #4011

kelson42 opened this issue Oct 1, 2024 · 2 comments
Assignees
Milestone

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Oct 1, 2024

We have a partial filesystem scanning feature to detect ZIM files (without having to sideload them manually):

  • This feature works for non-PS only versions of Kiwix-Android
  • This is a resource intensive process running in background
  • This does not run on the whole fs anymore
  • Has been conceived at a time there was no way to sideload manually a ZIM file
  • Kiwix Android is the only version of Kiwix having this kind of magic feature

Asking myself if we should not simply remove it.

@kelson42
Copy link
Collaborator Author

kelson42 commented Oct 1, 2024

@MohitMaliFtechiz Two questions:

  • Do are my bullet points correct?
  • Which parts of the fs are exactly scanned?
  • How often takes runs this process (what triggers it)?
  • What kind of impact would that have (beside having to sideload manually any ZIM file downloaded outside Kiwix)?

@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented Oct 1, 2024

This feature works for non-PS only versions of Kiwix-Android

@kelson42 Right it works for non-PS only(for loading the sideloaded zim files). But this also works in the PS variant(If the user directly puts the ZIM file in the app-specific directory(internal or public)).

This is a resource intensive process running in background

True.

This does not run on the whole fs anymore
Which parts of the fs are exactly scanned?

In the non-PS version the scanning does not work in the Android/data, and Android/obb folders as they are restricted folders. Apart from these folders, the scanning is working on the full file system.

Has been conceived at a time there was no way to sideload manually a ZIM file

It was introduced very long ago, and at that time, we do not have the file picker functionality(Especially for Android 11 and above, which now directly adds the ZIM file to the local library screen after picking).

How often takes runs this process (what triggers it)?

This scanning process only runs once when the user wants to scan the storage for ZIM files(It triggers when the user swipes down to refresh on the local library screen).

What kind of impact would that have (beside having to sideload manually any ZIM file downloaded outside Kiwix)?

The main impact is that we can not automatically load the sideloaded zim files, we have to manually load the ZIM files via "+" icon in the application. Also, if we remove the scanning from the application user has to manually load the ZIM files one by one in the application(Scanning automatically adds the whole ZIM files at once in the application).

The second impact will be for Samsung's users who are using the "My Files" device explorer since we can not open the ZIM files directly from the "My Files"(#4002), so in this case, this scanning feature will help users to load sideloaded ZIM files in the application. We can not rely on the file-picking functionality for non-PS variants since manufacturers can change the returning URI type like we have faced in the Samsung tablet in #4015.

Apart from this, there are no other impacts we will face. Since downloaded ZIM files(within the application) are directly showing in the application.

@kelson42 kelson42 modified the milestones: 3.12.0, 3.13.0 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants