Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support of Zimit1 ZIM files #3910

Open
kelson42 opened this issue Jun 28, 2024 · 5 comments
Open

Remove support of Zimit1 ZIM files #3910

kelson42 opened this issue Jun 28, 2024 · 5 comments
Assignees
Milestone

Comments

@kelson42
Copy link
Collaborator

We don't distribute such ZIM files anymore which have been almost all superseeded by Zimit2 ZIM files which don't rely anymore on ServiceWorker. Therefore all the tooling to get the ZIMit1 files is not necessary anymore and should be removed.

@kelson42
Copy link
Collaborator Author

@MohitMaliFtechiz @rgaudin The main question is when exactly? I see no urgency here but I would like to ask you if this feature/tooling has an impact for normal ZIM reading? Does it somehow slowdown the read of all "normal" ZIM?

@rgaudin
Copy link
Member

rgaudin commented Jun 28, 2024

From what I recall it was quite invasive.

@MohitMaliFtechiz
Copy link
Collaborator

@kelson42 It does not slow the reading of normal zim files, the service worker only provides the power to intercept the request of the service worker and we implement our own logic to load the data. If no service worker is available in any zim, the normal webViewClient callback gives us the same thing to load our own data. There is no slowdown in reading the normal zim files(Since they already loading via the webViewClient callback).

@Jaifroid
Copy link
Member

Jaifroid commented Jul 8, 2024

I'd urge a bit of caution and that you allow some time to ensure all the old Zimit1 archives have been successfully republished as Zimit2 (maybe that's already happened, but I'm not sure it's 100%). People will still have old Zimit1 archives that they cherish, and may want to keep them for some time. Do you really want to render them unreadable with the Android app, which was one of the only ways in which a Zimit1 archive could be successfully read? I know I've still got some that I don't think have been successfully replaced yet. E.g. the CIA World Factbook. It's no longer available in the zimit folder, but there is no alternative either... FYI I don't plan to deprecate support for zimit1 in KJS yet...

@MohitMaliFtechiz
Copy link
Collaborator

@Jaifroid I agree with your point. We should not remove the zimit1 support from the application as users can have these files. Maybe we can consider this ticket in the future when all the users are switched to zimit2, but for now, we should keep the support for zimit1.

@kelson42 kelson42 modified the milestones: 3.12.0, 3.11.3, 3.13.0 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants