Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise the gradle build script #31

Open
mgautierfr opened this issue Mar 22, 2023 · 0 comments
Open

Reorganise the gradle build script #31

mgautierfr opened this issue Mar 22, 2023 · 0 comments
Assignees
Milestone

Comments

@mgautierfr
Copy link
Member

With PR #27 merged we have now working build system and test.

However, the internal structure of the gradle build system is not perfect. For now we have :

  • target generateHeaderFilesFromJavaWrapper which generate the headers from the java class definition
  • target build which build the jni wrapper. It use the generated header but it doesn't have a dependency to generateHeaderFilesFromJavaWrapper.
  • target createCodeCoverageReport which create the test "binary", run it and then generate the code coverage report. But it create the test binary by recompiling the source of the jni wrapper inside itself.

It would be better to have:

  • target generateHeaders which generate the headers from the java class definition
  • target build which build the jni wrapper. As it needs the generated header, it depends of generateHeaders wrapper.
  • target buildTest which build the test binary. As it need to use the created jni wrapper (as if it was a simple user of the wrapper), it depends of build target.
  • target test which run the test binary. It depends of buildTest target.
  • target createCodeCoverageReport which depends of test target.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants