Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Release v0.9.0 #1563

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Release v0.9.0 #1563

merged 3 commits into from
Sep 14, 2021

Conversation

knrt10
Copy link
Member

@knrt10 knrt10 commented Sep 6, 2021

No description provided.

@ipochi ipochi force-pushed the release-v0.9.0 branch 4 times, most recently from 986d286 to ac5ae8f Compare September 8, 2021 15:22
@ipochi ipochi requested a review from surajssd September 8, 2021 15:24
@ipochi ipochi assigned iaguis and invidian and unassigned iaguis and invidian Sep 8, 2021
@ipochi ipochi requested review from iaguis and invidian September 8, 2021 15:24
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I left some comments with suggestions how I think we could improve the readability of changelog for end users.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
docs/installer/lokoctl.md Show resolved Hide resolved
Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is missing a script to update the bootstrap Kubelet and etcd.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@invidian
Copy link
Member

invidian commented Sep 9, 2021

Blocked by #1567.

@ipochi ipochi force-pushed the release-v0.9.0 branch 2 times, most recently from 100c109 to c3a262d Compare September 13, 2021 10:19
@ipochi
Copy link
Member

ipochi commented Sep 13, 2021

The PR is missing a script to update the bootstrap Kubelet and etcd.

added.

@ipochi ipochi requested review from surajssd and ipochi September 13, 2021 10:20
@ipochi ipochi requested a review from invidian September 13, 2021 10:20
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
scripts/update/0.8.0-0.9.0/cluster.sh Outdated Show resolved Hide resolved
scripts/update/0.8.0-0.9.0/update.sh Outdated Show resolved Hide resolved
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some remaining nits, overall looks nice :)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
invidian
invidian previously approved these changes Sep 13, 2021
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
scripts/update/0.8.0-0.9.0/cluster.sh Show resolved Hide resolved
knrt10 and others added 3 commits September 14, 2021 12:51
Release CHANGELOG and scripts to update controller and worker nodes:
etcd and host kubelet.

Signed-off-by: Imran Pochi <[email protected]>
Co-authored-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
@ipochi
Copy link
Member

ipochi commented Sep 14, 2021

@surajssd @iaguis @invidian

Upgrade steps and scripts tested for local and S3 backend.

Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ipochi ipochi merged commit 32b6a54 into master Sep 14, 2021
@ipochi ipochi deleted the release-v0.9.0 branch September 14, 2021 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants