-
Notifications
You must be signed in to change notification settings - Fork 49
Conversation
986d286
to
ac5ae8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I left some comments with suggestions how I think we could improve the readability of changelog for end users.
ac5ae8f
to
dc9c627
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is missing a script to update the bootstrap Kubelet and etcd.
dc9c627
to
d4b17de
Compare
Blocked by #1567. |
100c109
to
c3a262d
Compare
added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some remaining nits, overall looks nice :)
c66bb91
to
93f31fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments.
Release CHANGELOG and scripts to update controller and worker nodes: etcd and host kubelet. Signed-off-by: Imran Pochi <[email protected]> Co-authored-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
Signed-off-by: Imran Pochi <[email protected]>
93f31fc
to
0e98217
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.