We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related to kintone/js-sdk-ja#39.
The typescript dependency is missing on @kintone/dts-gen, so dts-gen causes an error during generating type definition file.
typescript
@kintone/dts-gen
v7.0.2
yarn add -D @kintone/dts-gen kintone-dts-gen --base-url $KINTONE_BASE_URL --api-token $KINTONE_API_TOKEN --app-id $APP_ID --type-name SampleFields --namespace company.name.types -o sample-fields.d.ts
User can execute dts-gen successfully without installing typescript manually. (When installing dts-gen, typescript should be installed automatically)
The dts-gen causes an error.
Error: Failed to load plugin '@typescript-eslint' declared in 'BaseConfig » @cybozu/eslint-config/presets/typescript » ../lib/typescript.js': Cannot find module 'typescript' Require stack: - /Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/util/astUtils.js - /Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/util/index.js - /Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/rules/adjacent-overload-signatures.js - /Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/rules/index.js - /Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/index.js - /Users/tasshi/Downloads/test-dts-gen/node_modules/@eslint/eslintrc/dist/eslintrc.cjs Referenced from: /Users/tasshi/Downloads/test-dts-gen/node_modules/@cybozu/eslint-config/lib/typescript.js at Function.Module._resolveFilename (node:internal/modules/cjs/loader:956:15) at Function.Module._load (node:internal/modules/cjs/loader:804:27) at Module.require (node:internal/modules/cjs/loader:1028:19) at require (node:internal/modules/cjs/helpers:102:18) at Object.<anonymous> (/Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/util/astUtils.js:30:25) at Module._compile (node:internal/modules/cjs/loader:1126:14) at Object.Module._extensions..js (node:internal/modules/cjs/loader:1180:10) at Module.load (node:internal/modules/cjs/loader:1004:32) at Function.Module._load (node:internal/modules/cjs/loader:839:12) at Module.require (node:internal/modules/cjs/loader:1028:19) { code: 'MODULE_NOT_FOUND', requireStack: [ '/Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/util/astUtils.js', '/Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/util/index.js', '/Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/rules/adjacent-overload-signatures.js', '/Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/rules/index.js', '/Users/tasshi/Downloads/test-dts-gen/node_modules/@typescript-eslint/eslint-plugin/dist/index.js', '/Users/tasshi/Downloads/test-dts-gen/node_modules/@eslint/eslintrc/dist/eslintrc.cjs' ] } error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
@cybozu/eslint-config includes typescript (and eslint) in peerDeps, so we need to add typescript to our deps manually. https://github.com/cybozu/eslint-config/blob/master/package.json#L41
$ yarn add -D @kintone/dts-gen yarn add v1.22.19 warning package.json: No license field warning No license field [1/4] 🔍 Resolving packages... [2/4] 🚚 Fetching packages... [3/4] 🔗 Linking dependencies... warning "@kintone/dts-gen > @cybozu/[email protected]" has unmet peer dependency "typescript@^3.3.3333 || ^4.0.0 || ^5.0.0". warning "@kintone/dts-gen > @cybozu/eslint-config > @typescript-eslint/eslint-plugin > [email protected]" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".
WA: Install typescript manually
System: OS: macOS 13.4 CPU: (10) arm64 Apple M1 Max Memory: 179.47 MB / 64.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 16.17.0 - ~/.nodenv/versions/16.17.0/bin/node Yarn: 1.22.19 - /opt/homebrew/bin/yarn npm: 8.19.2 - ~/.nodenv/versions/16.17.0/bin/npm npmPackages: @kintone/dts-gen: ^7.0.2 => 7.0.2
The text was updated successfully, but these errors were encountered:
We decided not to do any implementation to fix it.
TypeScript is specified in peerDeps of @cybozu/eslint-config. npm and pnpm install peerDeps automatically. This issue only happens with Yarn.
Sorry, something went wrong.
No branches or pull requests
Summary
Related to kintone/js-sdk-ja#39.
The
typescript
dependency is missing on @kintone/dts-gen, so dts-gen causes an error during generating type definition file.Target Package
@kintone/dts-gen
Target Version
v7.0.2
Reproduction
Expected Behavior
User can execute dts-gen successfully without installing typescript manually.
(When installing dts-gen, typescript should be installed automatically)
Actual Behavior
The dts-gen causes an error.
@cybozu/eslint-config includes typescript (and eslint) in peerDeps, so we need to add typescript to our deps manually.
https://github.com/cybozu/eslint-config/blob/master/package.json#L41
WA: Install typescript manually
Environment
The text was updated successfully, but these errors were encountered: