Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong argument order of _update_mems function! #118

Open
jech2 opened this issue Aug 25, 2020 · 1 comment
Open

wrong argument order of _update_mems function! #118

jech2 opened this issue Aug 25, 2020 · 1 comment

Comments

@jech2
Copy link

jech2 commented Aug 25, 2020

In transformer-xl/pytorch/mem_transformer.py,
I found the argument order of _update_mems ftn(member of class MemTransformerLM) is wrong!
< See difference >
619th line :
def _update_mems(self, hids, mems, qlen, mlen):
733th line :
new_mems = self._update_mems(hids, mems, mlen, qlen)

I tested the code when qlen == mlen, so the code worked without any problem,
but the code should be corrected, for the case when qlen != mlen.
Thanks!

@lujiarui-iie
Copy link

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants