Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for searching payment/transaction based on First or second reference ID #86

Open
daliwei opened this issue Feb 22, 2017 · 1 comment

Comments

@daliwei
Copy link

daliwei commented Feb 22, 2017

No description provided.

@pierre
Copy link
Member

pierre commented Feb 23, 2017

Note that since killbill/killbill@461fcc8, both reference ids aren't stored in Kill Bill anymore. They're only exposed through the payment plugin APIs.

To implement this search, first of all, the searchPayments and / or searchPaymentMethods need to be correctly implemented in the plugin(s) (a default search criteria is typically generated in the plugin frameworks, to be tweaked as needed). See how the Litle plugin does it for instance to search Litle transaction ids.

I would suggest focusing on this first, making sure this search is correctly implement and performs at scale (I'm expecting new indexes to be needed in the plugin tables).

Once this is done, it could easily be integrated in Kaui, since the main search APIs can be delegated to plugins when withPluginInfo=true. For instance, if payment:FOO is searched, we could first search in Kill Bill, and if there is no match, then perform the search again in the plugins (

payments = Kaui::Payment.list_or_search(search_key, offset, limit, options_for_klient)
). That way, we could look-up payments given a gateway reference id, even if the plugin name isn't known for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants