Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Transfer bundle Policy options consistent with API #320

Open
KBbitsP opened this issue Oct 3, 2022 · 7 comments
Open

Making Transfer bundle Policy options consistent with API #320

KBbitsP opened this issue Oct 3, 2022 · 7 comments
Assignees

Comments

@KBbitsP
Copy link
Contributor

KBbitsP commented Oct 3, 2022

Issue : Currently when a bundle is transferred from one account to another using Kaui, the screen does not give any option to select the transfer policy and uses End_Of_Term as the default value. On the other hand, the same operation when performed via the API gives the option to select out of Start_Of_Term, Immediate OR End_Od_Term policy just like at the time of cancelling.

image

Expected behavior : The behavior and options should be consistent between the admin ui and the API ( https://killbill.github.io/slate/#bundle-transfer-a-bundle-to-another-account ).

@KBbitsP
Copy link
Contributor Author

KBbitsP commented Oct 3, 2022

This is interlinked to the below issue :

https://github.com/killbill/killbill/issues/1775

@kpbacode
Copy link
Contributor

kpbacode commented Oct 4, 2022

Screenshot 2022-10-04 at 13 26 15

@kpbacode
Copy link
Contributor

kpbacode commented Oct 6, 2022

#321

@reshmabidikar
Copy link
Contributor

reshmabidikar commented Oct 14, 2022

Looks good (see screenshot below). A few comments:

  1. Currently, the billing policy defaults to IMMEDIATE. Wondering if we should default it to END_OF_TERM to keep it consistent with the API?
  2. As per @KBbitsP, there is an issue when the START_OF_TERM policy is specified (#1775). So, should the START_OF_TERM policy be disabled in Kaui until this issue is fixed?

image

@reshmabidikar
Copy link
Contributor

Any thoughts @pierre?

@pierre
Copy link
Member

pierre commented Oct 18, 2022

Agreed x2!

@reshmabidikar
Copy link
Contributor

FYI @kpbacode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants