Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding 1 standalone subscription multiple times in the same bundle #289

Closed
hieusharp opened this issue Jan 19, 2022 · 5 comments
Closed
Assignees

Comments

@hieusharp
Copy link

  1. Create a standalone subscription.
  2. In the "Add standalone subscription" dropdown select the same subscription.
@tungleduyxyz tungleduyxyz self-assigned this Jul 2, 2023
@tungleduyxyz
Copy link
Contributor

Hi @reshmabidikar ,
Can you help me to clarify this ticket?
I'm not quite sure where to Add standalone subscription

@reshmabidikar
Copy link
Contributor

I gave it a try and here are the steps to reproduce it:

  1. Upload the monthly-standalone-no-trial catalog
  2. Create a new account
  3. Create a new subscription to the standard-monthly plan
  4. In the subscription screen, click Add Standalone subscription (See screenshot below):
image
  1. Select the standard-monthly plan and click Save - The subscription is added successfully to the bundle. Expected behavior: This should not be allowed since the bundle already includes the standard-monthly plan. @pierre, could you please confirm this? So, it should not be possible to add the same plan to the bundle but it should be possible to add a different standalone plan?

@pierre
Copy link
Member

pierre commented Jul 5, 2023

Actually, this is supported: you can have multiple standalone subscriptions in the same bundle, regardless of their plan. A standalone product is simply a product that cannot have add-ons (we shouldn't allow to add add-ons in the same bundle. mixed with standalone subscriptions). See https://docs.killbill.io/latest/userguide_subscription.html#_product_categories

BTW Your usecase could be solved using quantity nowadays - not sure if Kaui supports it yet though (if not, let's create a ticket for the work). See killbill/killbill#1651

@reshmabidikar
Copy link
Contributor

Actually, this is supported:

Okay, in that case, can we close this ticket? This ticket seems to indicate that such a behavior should not be supported.

we shouldn't allow to add add-ons in the same bundle. mixed with standalone subscriptions

Kaui already handles this. So, when the Add standalone subscription button is clicked, only the standalone subscriptions are listed. @tungleduyxyz, could you please confirm this?

not sure if Kaui supports it yet though (if not, let's create a ticket for the work)

Done, I've filed #363.

@tungleduyxyz
Copy link
Contributor

tungleduyxyz commented Jul 5, 2023

Hi @reshmabidikar

So, when the Add standalone subscription button is clicked, only the standalone subscriptions are listed

Yes, that's correct
I added a catalog with 2 plans,
image
And when I go to Add standalone subscription part, it only displays the Standalone
image

@pierre pierre closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants