require ../util/requireOptional not in right path #15

ivanclaud · 2016-12-06T07:07:54Z

HI

On file lib/transports/nodemailer/index.js required path for ./util/requireOptional seems to be incorrect. It should have been ../../util/requireOptional

Also one more issue on lib/util/requireOptional.js

Options packages require code seems to be incorrect
return require('pkg');

As per my knowledge it should have been
return require(pkg);

@ivanclaud

I had to make the same fixes that I later saw suggested by @ivanclaud to get this working locally.

scipe · 2019-03-22T13:53:20Z

@ivanclaud just install Neagle's version instead of keystone-email:
npm i https://github.com/neagle/keystone-email.git#fix-nodemailer

ivanclaud mentioned this issue Dec 8, 2016

Nodemailer transport doesn't found #14

Open

neagle pushed a commit to neagle/keystone-email that referenced this issue Dec 8, 2016

Fix requireOptional error and nodemailer require, fix keystonejs#15

7540d1c

I had to make the same fixes that I later saw suggested by @ivanclaud to get this working locally.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

require ../util/requireOptional not in right path #15

require ../util/requireOptional not in right path #15

ivanclaud commented Dec 6, 2016

scipe commented Mar 22, 2019

require ../util/requireOptional not in right path #15

require ../util/requireOptional not in right path #15

Comments

ivanclaud commented Dec 6, 2016

scipe commented Mar 22, 2019