-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove message object for chat.send
#96
Comments
I'm ok either way. I wouldn't worry about breaking changes since I think no one is using our module yet, and our README has warnings about its instability. But we can do an appropriate version upgrade. I think the question to ask for this change is whether
these aren't "options" they're what is being sent. Or will sending an attachment be an entirely different function call? In which case your change makes sense. Hmm. how about this: we just wait a bit until wde do attachments and then decide |
Good point. I was thinking attachments would be a different method, since that's what we do in the command line |
Given that we now have a separate attach method, @malgorithms what do you think about this? Both the Go and Python bots just accept strings instead of the message object. |
sure, just make sure it's a big version upgrade since it'll break all existing bots. |
It feels a bit odd to me to have the
ChatMessage
type for use on the bot'schat.send
method. For reference,ChatMessage
looks like:I think it's simpler for users to just input the text (
body
) of their message directly and let thechat.send
method handle the formatting of arguments for them. Ideally, usage ofchat.send
would look like:@malgorithms @thebearjew thoughts? This would be a breaking change.
The text was updated successfully, but these errors were encountered: