Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure out how to speed up tests #103

Open
malgorithms opened this issue Jan 17, 2019 · 3 comments
Open

figure out how to speed up tests #103

malgorithms opened this issue Jan 17, 2019 · 3 comments

Comments

@malgorithms
Copy link
Contributor

I had to add --runInBand to package.json because the wallet test and chat test are racing each other. For example, one of the chat tests posts a message and then "peeks" at it and makes sure it's not read. But the wallet test also sends messages, and so the chat test ends up failing.

@nathanmsmith
Copy link
Contributor

I was talking with @xgess this summer and he was of the opinion that rather that exhaustively test all api options in this or the other bot libs, we should have some sort of framework in client for testing all api methods extensively, and then a much less rigorous suite of tests (likely just one test to check the successful path of each method) in the bot libs. I think this would help speed up the tests in this project specifically, as we have a large amount of tests that seemed more concerned with testing the actual api logic that the bot logic.

@xgess
Copy link
Contributor

xgess commented Oct 7, 2019

mostly just concerned with test duplication if we are exhaustively testing API logic in all of the bot libraries. i think there's a reasonable case to be made for one of the bot libraries to be the flagship one with loads more testing than the others. we have a big head start here, we just shouldn't rewrite them all in python and go.

@malgorithms
Copy link
Contributor Author

I'm ok with tests in the client too, I just feel strongly the test suite on the JS side should run end-to-end tests like it has now. For any time spent adding a feature to this library, it's maybe like 5% extra effort to write tests. And the tests can catch errors in the bot library itself that are outside the api call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants