Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix spell checker #199

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: fix spell checker #199

merged 1 commit into from
Oct 9, 2024

Conversation

cesar19004
Copy link
Contributor

@cesar19004 cesar19004 commented Sep 18, 2024

Whatsie resolves the dictionaries path at runtime, but Qt WebEngine has its own way to resolve the dictionaries path using QTWEBENGINE_DICTIONARIES_PATH.

If QTWEBENGINE_DICTIONARIES_PATH is set, the spellchecker uses the dictionaries in the specified directory without looking anywere else. Otherwise, it uses the qtwebengine_dictionaries directory relative to the executable if it exists. If it does not exist, it will look in QT_INSTALL_PREFIX/qtwebengine_dictionaries.

This might lead to Qt WebEngine not finding dictionaries or having different dictionaries than Whatsie.

An example would be if Whatsie found the right path and Qt WebEngine did not; the dictionaries would show in settings, but the spell checker would not work, as described in #78 and #79.

To avoid that scenario, this PR sets QTWEBENGINE_DICTIONARIES_PATH to the path resolved by dictionaries.cpp.

So, this PR should fix #78 and fix #79.

#156 and the comments in 90210de might be related to the QTWEBENGINE_DICTIONARIES_PATH env var being set at the system level to a wrong or empty directory.

Make sure Qt WebEngine uses the dictionaries path resolved by the app
@keshavbhatt keshavbhatt merged commit 40da519 into keshavbhatt:main Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spell checker doesn't work Dictionary
2 participants