Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whatsie resolves the dictionaries path at runtime, but Qt WebEngine has its own way to resolve the dictionaries path using
QTWEBENGINE_DICTIONARIES_PATH
.This might lead to Qt WebEngine not finding dictionaries or having different dictionaries than Whatsie.
An example would be if Whatsie found the right path and Qt WebEngine did not; the dictionaries would show in settings, but the spell checker would not work, as described in #78 and #79.
To avoid that scenario, this PR sets
QTWEBENGINE_DICTIONARIES_PATH
to the path resolved by dictionaries.cpp.So, this PR should fix #78 and fix #79.
#156 and the comments in 90210de might be related to the
QTWEBENGINE_DICTIONARIES_PATH
env var being set at the system level to a wrong or empty directory.