Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slick-Cloned adding empty ids that are flagged on W3C validation & parsing reports #4288

Open
Darren404 opened this issue Feb 12, 2024 · 1 comment

Comments

@Darren404
Copy link

Darren404 commented Feb 12, 2024

Hi,
Not sure if this is the right place to ask this but we are using slick with slick cloned to have an infinitely scrolling section where items are repeated. The opener of each div in the code when inspected in the browser is rendering like this when it is cloned...

<div class="slick-slide slick-cloned" data-slick-index="4" id="" aria-hidden="true" tabindex="-1">

Using the W3C Nu HTML Checker via the bookmarklet shows these empty IDs are being flagged as errors due to duplication.
Is this a know issue with a fix or something not raised before? Is there a way to stop it generating IDs completely?

Thanks

@Rahafbawab
Copy link

Rahafbawab commented Aug 25, 2024

Hi,
I faced the same issue. here my fix
In slick.js line 2423 - version 1.8.1

$(_.$slides[slideIndex]).clone(true).attr('id', 'slick-cloned' + _.instanceUid + slideIndex)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants