Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: URI must be ascii only #33

Open
roTokyo opened this issue Mar 7, 2019 · 12 comments · May be fixed by #46
Open

Error: URI must be ascii only #33

roTokyo opened this issue Mar 7, 2019 · 12 comments · May be fixed by #46
Assignees
@keithmifsud
Labels
bug Something isn't working enhancement New feature or request investigating

Comments

@roTokyo
Copy link

roTokyo commented Mar 7, 2019

Thanks you for your plug-in!
I would like to use it but some of the URL I use have Kanji's.
Do you think you'll upgrade in a future?
@keithmifsud
Copy link
Owner

Hi @roTokyo you're welcome 😄 What is "Kanji" please?

@keithmifsud keithmifsud added the question Further information is requested label Mar 7, 2019
@keithmifsud keithmifsud self-assigned this Mar 7, 2019
@roTokyo
Copy link
Author

roTokyo commented Mar 7, 2019 via email

@keithmifsud keithmifsud added the enhancement New feature or request label Mar 8, 2019
@keithmifsud
Copy link
Owner

Thanks for the explanation in 🇨🇳 I'd love to help but I wouldn't even know where to start. If anyone want to take this up I will help with testing etc.

@roTokyo
Copy link
Author

roTokyo commented Mar 8, 2019 via email

@keithmifsud
Copy link
Owner

Hi again,

I think this should still work as it is though. If you have time, please give an example of the URLs you tried, some that worked and some that did not. If your repo is public, please share it too. I'll take another look at it asap.

@keithmifsud keithmifsud added bug Something isn't working investigating and removed question Further information is requested labels Mar 8, 2019
@roTokyo
Copy link
Author

roTokyo commented Mar 13, 2019 via email

@keithmifsud
Copy link
Owner

Hi.. no worries 😄

Does the site compile without this plugin? URI is used by Jekyll itself too. It's a Ruby library. This plugin also uses it. Please let me know if the site builds fine with this plugin disabled. If it is, then I can try a few things.

Thanks

@roTokyo
Copy link
Author

roTokyo commented Mar 13, 2019 via email

@roTokyo
Copy link
Author

roTokyo commented Mar 14, 2019 via email

@roTokyo
Copy link
Author

roTokyo commented Mar 14, 2019 via email

This was referenced Sep 13, 2019
Closed
Closed
@keithmifsud
Copy link
Owner

Hi @roTokyo .. very sorry for my late correspondence. Been a busy year :) Is the issue fixed on your side? If not, I can assist you this week. Thanks :)

mukrop added a commit to mukrop/jekyll-target-blank that referenced this issue Oct 27, 2019
@mukrop
Add support for Unicode links
e4b9c32 
* In function 'external?', URI is now escaped before split.
* This adheres to the recommendation in the URI docs: https://www.rubydoc.info/stdlib/uri/URI.parse
* Resolves keithmifsud#33.
@mukrop mukrop linked a pull request Oct 27, 2019 that will close this issue
Open
mukrop added a commit to mukrop/jekyll-target-blank that referenced this issue May 13, 2020
@mukrop
Add support for Unicode links
cb52540 
* In function 'external?', URI is now escaped before split.
* Resolves keithmifsud#33.
mukrop added a commit to mukrop/jekyll-target-blank that referenced this issue May 13, 2020
@mukrop
Add support for Unicode links
9c98826 
* In function 'external?', URI is now escaped before split.
* More info on deprecation on https://docs.knapsackpro.com/2020/uri-escape-is-obsolete-percent-encoding-your-query-string
* Resolves keithmifsud#33.
mukrop added a commit to mukrop/jekyll-target-blank that referenced this issue May 13, 2020
@mukrop
Add support for Unicode links
19bcd19 
* In function 'external?', URI is now escaped before split.
* Resolves keithmifsud#33.
mukrop added a commit to mukrop/jekyll-target-blank that referenced this issue Dec 5, 2020
@mukrop
Add support for Unicode links
6438850 
* In function 'external?', URI is now escaped before split.
* Class Addressable is used for parsing since it is capable of parsing Unicode URIs (IRIs). Another option would be to escape the URI before parsing but URI.escape is deprecated and alternatives (e.g. CGI.escape) work differently.
* Resolves keithmifsud#33.
@roTokyo
Copy link
Author

roTokyo commented Mar 7, 2021 via email

@bittlingmayer bittlingmayer mentioned this issue Jun 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keithmifsud keithmifsud

Labels
bug Something isn't working enhancement New feature or request investigating
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Unicode links mukrop/jekyll-target-blank
Add support for Unicode links
2 participants
@keithmifsud @roTokyo