Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction ID may be Text rather than Integer #45

Open
steverabino opened this issue May 21, 2017 · 1 comment
Open

Transaction ID may be Text rather than Integer #45

steverabino opened this issue May 21, 2017 · 1 comment
Labels

Comments

@steverabino
Copy link

According to https://developers.google.com/analytics/devguides/collection/analyticsjs/ecommerce#transaction and https://developers.google.com/analytics/devguides/collection/analyticsjs/ecommerce#item, Transaction ID in each of these scenarios is a Text field.

However, I believe GA Debugger is parsing the ID as an integer, which gives us a different result to GA when using Transaction IDs that are not pure Integers.

I think this is being done https://github.com/keithclark/gadebugger/blob/master/src/core/utmBeacon.js#L246 and https://github.com/keithclark/gadebugger/blob/master/src/core/utmBeacon.js#L262.

cc/ @NGMarmaduke who originally found the issue

@keithclark
Copy link
Owner

Hey Steve!

Thanks for taking the time to do the investigation work - that makes complete sense to me. I'll get a fix ready for the next release.

@keithclark keithclark added the bug label Sep 14, 2017
@keithclark keithclark added this to the web extensions milestone Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants