Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceAccount resource is not considered as part of the reconciliation loop #86

Open
diranged opened this issue Aug 3, 2021 · 0 comments

Comments

@diranged
Copy link
Contributor

diranged commented Aug 3, 2021

Is this a BUG REPORT or FEATURE REQUEST?:

Bug reeport

What happened:

We have noticed that there is no reconciliation loop for ensuring that the ServiceAccount resource is created (if desired) and that the ISRA annotations are in place. This means that you have one chance and one chance only to get that created, and if anything breaks it later, you are out of luck.

What you expected to happen:

I expect the controller to continually work to ensure the desired state of the world is the state discovered in the Kubernetes API.

How to reproduce it (as minimally and precisely as possible):

Create a new Iamrole resource that creates a matching ServiceAccount resource. Then go and delete that ServiceAccount resource. You will find that it is not re-created or checked at any point. Same thing if you change, delete, or update the ISRA annotation.

Anything else we need to know?:

This was discovered as part of #83 ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant