Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update status issue #58

Merged
merged 1 commit into from
Sep 26, 2020
Merged

Conversation

kshamajain99
Copy link
Collaborator

@kshamajain99 kshamajain99 commented Sep 25, 2020

close #57

Could you share the solution in high level?
kubernetes/kubernetes#86811

Could you share the test results?

Screen Shot 2020-09-25 at 4 36 14 PM

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #58 into master will decrease coverage by 1.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   67.16%   66.12%   -1.05%     
==========================================
  Files           8        8              
  Lines        1063      989      -74     
==========================================
- Hits          714      654      -60     
+ Misses        316      304      -12     
+ Partials       33       31       -2     
Impacted Files Coverage Δ
controllers/iamrole_controller.go 9.04% <0.00%> (-0.24%) ⬇️
pkg/validation/validate.go 75.32% <0.00%> (-4.47%) ⬇️
internal/config/properties.go 65.35% <0.00%> (-2.46%) ⬇️
internal/utils/oidc.go 80.43% <0.00%> (-1.57%) ⬇️
internal/utils/utils.go 80.00% <0.00%> (-0.89%) ⬇️
pkg/awsapi/sts.go 0.00% <0.00%> (ø)
pkg/awsapi/iam.go 88.09% <0.00%> (+0.16%) ⬆️
pkg/awsapi/eks.go 68.96% <0.00%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc59eb...17a91d6. Read the comment docs.

@kshamajain99 kshamajain99 merged commit b493169 into keikoproj:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to update status
2 participants