Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vdiffr in graphical snapshot tests #175

Open
nanxstats opened this issue Nov 14, 2024 · 0 comments · May be fixed by #176
Open

Use vdiffr in graphical snapshot tests #175

nanxstats opened this issue Nov 14, 2024 · 0 comments · May be fixed by #176
Assignees
@nanxstats
Labels
enhancement

Comments

@nanxstats
Copy link
Collaborator

Currently, snapshot tests involving generating plots:

  • Generate PNG outputs that are not reproducible across R or OS versions.
  • The snapshot files are not stored with the package, generating confusing Git new directory diffs every time the test is ran. Nothing can be compared to so that the tests will always pass.

We should use the proper solution vdiffr::expect_doppelganger() which stores and compares reproducible SVG outputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanxstats nanxstats

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor graphical tests with vdiffr::expect_doppelganger() keaven/gsDesign
1 participant
@nanxstats