Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestParseIdentifier and TestParseBareIdentifier are identical #2

Open
borland opened this issue Jan 22, 2021 · 0 comments
Open

TestParseIdentifier and TestParseBareIdentifier are identical #2

borland opened this issue Jan 22, 2021 · 0 comments

Comments

@borland
Copy link

borland commented Jan 22, 2021

The unit test TestParseIdentifier (trunk@59ced546f5227abcbd0b4c8a7d5bcddcb8ba6667) is identical to TestParseBareIdentifier.

Both call the parseBareIdentifier function, so parseIdentifier isn't directly covered. Seems like a minor typo?

Changing https://github.com/hkolbeck/kdl4j/blob/trunk/src/test/java/dev/hbeck/kdl/parse/TestParseBareIdentifier.java line 46 to call parseIdentifier results in a passing unit test calling the correct function, but should it have a different set of test data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant