Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Jasmine tests are identified wrong in TeamCity #17

Open
stevebroshar opened this issue Apr 11, 2014 · 5 comments
Open

Jasmine tests are identified wrong in TeamCity #17

stevebroshar opened this issue Apr 11, 2014 · 5 comments

Comments

@stevebroshar
Copy link

I'm using jasmine where tests are named/identified based on the test description plus each containing describe block description. For example:

describe('dockDirective', function(){
  describe('click-handler', function(){
    it('should set window active', ...)
  });
});

defines the test "dockDirective click-handler should set window active".

But, when I run the test in TeamCity with Karma, the test is identified as "should set window active (dockDirective click-handler.PhantomJS 1.9.0 (Windows 7))". The information (plus extra) is in there, but in the wrong order. It's hard to read.

I ran the same command outside of TeamCity and see that the raw output is like this:

##teamcity[testSuiteStarted name='dockDirective click-handler.PhantomJS 1.9.0 (Windows 7)']
##teamcity[testStarted name='should set window active']

Seems that to make it look right in TC, the output should include the suite text in each test name like this:

##teamcity[testSuiteStarted name='dockDirective click-handler.PhantomJS 1.9.0 (Windows 7)']
##teamcity[testStarted name='dockDirective click-handler should set window active']
@memark
Copy link

memark commented Jun 21, 2015

I've also noticed this. What I'd like to do is actually split up the ##teamcity[testSuiteStarted name='dockDirective click-handler.PhantomJS 1.9.0 (Windows 7)'] string into properly nested "suites". I have yet to figure out if this caused by the reporter, or by Karma itself. I'd be happy to do some coding, but it would be nice to get an official response first, endorsing the idea, and pointing me in the right direction!

(If this project is even alive? The build seems to have been broken for the past 5 months. :-()

@stevebroshar
Copy link
Author

I wonder myself whether the project is alive ... still loved by any of its developers. I submitted this issue well over a year ago. I submitted an issue with karma-safari-launcher karma-runner/karma-safari-launcher#12 a month ago. Neither have had any progress towards a fix. I don't know whether karma in general is dead/unloved, or maybe it's just that some of the peripheral components get less attention/love.

@dignifiedquire
Copy link
Member

@stevebroshar I'm really sorry about that. The fact is that I'm nearly working alone on the karma code base, and that only in my free time so I'm simply not getting to some modules as quickly as I would like to. If you want to help out by investigation/writing PRs I'm more than happy to accept the help, but otherwise things simply progress not very fast right now.

@memark
Copy link

memark commented Jun 22, 2015

@dignifiedquire No problem, that's perfectly understandable. I'd just like some basic input on this idea, before I start coding. No fun writing a PR if it never gets accepted later on. :)

@dignifiedquire
Copy link
Member

@memark I personally don't use teamcity so I have to rely on you guys to guide me when it comes to needed features. Your suggestion does sound good though so I'm happy to look at PR from you :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants