Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for <script type="text/ng-template"> templates #42

Closed
wants to merge 5 commits into from

Conversation

arkarkark
Copy link

fixes #31

@arkarkark
Copy link
Author

Hi, I'm wondering what you thought of this PR? I kinda need it for my project and I'd rather not fork your project if this'll get accepted soon.

@arkarkark
Copy link
Author

forked as npm package karma-ng-html2js-preprocessor-with-templates

also removed the ng-html preprocessor

@willhlaw
Copy link

willhlaw commented Nov 4, 2014

The PR worked well for me. Nice work @arkarkark.

@dignifiedquire
Copy link
Member

Thanks @arkarkark and sorry for the late feedback, it would be great if you could

  • remove the changes to .travis.yml and package.json
  • squash all commits into one and follow our commit message convention
  • rebase onto the latest master to resolve the merge issues

then I can get this in finally

@arkarkark
Copy link
Author

heh, yah, I'll get to it but likely not for a few weeks. Will do all you suggest though.That'll be in another PR so closing this one.

@erickcsh
Copy link

erickcsh commented Aug 5, 2016

@arkarkark is there any chance you'll get into this soon?

@arkarkark
Copy link
Author

It has passed the year anniversary of me saying I'll get to it. I've had it in my todo unread email queue for ages, I will try and get to it. sorry.

@arkarkark
Copy link
Author

I had a go... I got it to work, but couldn't get the tests working how it looked like they wanted to. I'm going to give up on this, you can use it as a starting block to start again if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need a way to inject template in script tag format
4 participants