-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for <script type="text/ng-template"> templates #42
Conversation
Hi, I'm wondering what you thought of this PR? I kinda need it for my project and I'd rather not fork your project if this'll get accepted soon. |
forked as npm package karma-ng-html2js-preprocessor-with-templates also removed the ng-html preprocessor |
The PR worked well for me. Nice work @arkarkark. |
Thanks @arkarkark and sorry for the late feedback, it would be great if you could
then I can get this in finally |
heh, yah, I'll get to it but likely not for a few weeks. Will do all you suggest though.That'll be in another PR so closing this one. |
@arkarkark is there any chance you'll get into this soon? |
It has passed the year anniversary of me saying I'll get to it. I've had it in my todo unread email queue for ages, I will try and get to it. sorry. |
I had a go... I got it to work, but couldn't get the tests working how it looked like they wanted to. I'm going to give up on this, you can use it as a starting block to start again if you want. |
fixes #31