Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

karma-jasmine reports pending specs as errors when karma-junit-reporter used. #112

Closed
staticcat opened this issue Mar 31, 2016 · 1 comment

Comments

@staticcat
Copy link

I have the following pending spec define in a jasmine test.

describe("Pending specs", function (){

    xit("can be declared 'xit'", function () {
        expect(true).toBe(false);
    });

    it("can be declared with 'it' but without a function");

    it("can be declared by calling 'pending' in the spec body", function () {
        expect(true).toBe(false);
        pending('this is why it is pending');
    });
});

When written out by the karma-junit-reporter I get a skipped and failed result. This leads me to believe the test has been run, or given a result when it should have none.

I have also reported this to karma-junit-reporter.
karma-runner/karma-junit-reporter#90

@maksimr
Copy link
Contributor

maksimr commented Apr 23, 2016

@staticcat karma-jasmine pass flag skipped

Seem karma-junit-reporter does not handled this flag

Thanks

@maksimr maksimr closed this as completed Apr 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants