Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process hangs in event of transpilation error #14

Open
waynegerard opened this issue Dec 31, 2013 · 0 comments
Open

Process hangs in event of transpilation error #14

waynegerard opened this issue Dec 31, 2013 · 0 comments

Comments

@waynegerard
Copy link

If there's a transpilation error, we get a nice log message indicating where the error occurred, but the process hangs indefinitely because the finish callback is never executed (rightfully so, since it would probably cause many other errors down the line).

Unfortunately this has the nasty side effect that anything depending on the process to finish (e.g. a deployment script) will hang indefinitely as well. I think it'd be nice to add the ability to have a callback executed in the event of a transpilation error. I've made the corresponding change here:

https://github.com/waynegerard/karma-coffee-preprocessor/commit/2255cb4687debf080eebdb9144ad02665e9726a0

But just wanted to hear feedback before making a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant