Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CumulativeAnalyzableBase.ComputeByIndexImpl call ComputeCumulativeValue twice for the same index #95

Open
ljason1 opened this issue Jun 8, 2019 · 0 comments
Open

CumulativeAnalyzableBase.ComputeByIndexImpl call ComputeCumulativeValue twice for the same index #95

ljason1 opened this issue Jun 8, 2019 · 0 comments

Comments

@ljason1
Copy link

ljason1 commented Jun 8, 2019

The line #43 of CumulativeAnalyzableBase.cs should be LastCacheIndex = index; instead of LastCacheIndex = index - 1;
it make ComputeCumulativeValue be called twice for the same index (cause ParabolicStopAndReverse calculate wrong values)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ljason1