Library incompatible w/ newer versions of CsvHelper

[onionhammer]

This is more of an issue with CsvHelper making a breaking change by adding a CultureInfo parameter to their constructors, but I think it'd be good to get this updated. If your app is using this library and CsvHelper latest, this library will break because it cant find a matching constructor without CultureInfo.

Great library btw, I'm so happy I discovered it :)

[onionhammer]

I'm thinking maybe I should just fork this and use a separate nuget package?

[ridicoulous]

I do it.

https://www.nuget.org/packages/Trady.Core.Fork/

https://github.com/ridicoulous/Trady

[onionhammer]

@ridicoulous hmm, what's your goal? To tailor this lib for your own purposes or to fix bugs/shortcomings of this lib?

[ridicoulous]

@onionhammer first of all my own purposes and may be a little bit of improvements. For example, I added TEMA indicator

[onionhammer]

@ridicoulous Hmm, to fork the nuget packages I would have to produce like 6 nuget packages, not just 1. Any interest in upgrading CsvHelper in your fork?

[ridicoulous]

@ridicoulous Hmm, to fork the nuget packages I would have to produce like 6 nuget packages, not just 1. Any interest in upgrading CsvHelper in your fork?

No problem to upgrade