Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber options not being honoured #532

Closed
ghost opened this issue Sep 17, 2018 · 3 comments
Closed

Cucumber options not being honoured #532

ghost opened this issue Sep 17, 2018 · 3 comments
Assignees

Comments

@ghost
Copy link

ghost commented Sep 17, 2018

Related to #529

When running Junit runner from command line using karate version 0.9.0.RC2, cucumber options are not being honoured.

eg java -jar -Dcucumber.options="--tags ~@ignore" target/broken-karate-test-jar-with-dependencies.jar

Code available in: https://github.com/ali-nutmeg/broken-karate

Thanks.

@ptrthomas ptrthomas self-assigned this Sep 17, 2018
@ptrthomas ptrthomas added the bug label Sep 17, 2018
@ptrthomas ptrthomas added this to the 0.9.0 milestone Sep 17, 2018
@ptrthomas
Copy link
Member

@ali-nutmeg this is tremendously helpful, thank you so much.

fixed. can you try once by building from source ?

@ghost
Copy link
Author

ghost commented Sep 17, 2018

works perfectly!
Would you be happy to release RC3 as well please?

Thanks a lot!

PS I don't know if you want me to close these tickets now or you'll close it after creating the final release

@ptrthomas
Copy link
Member

@ali-nutmeg only too happy to assist, you've really helped iron out a couple cases I missed, and where unit-tests are too hard to put in place. RC3 did not feel right please find 0.9.0.RC2.1 just published

@ptrthomas ptrthomas removed this from the 0.9.0 milestone Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant