DoubleClick ads are not loaded.

[andrzejkrecicki]

DoubleClick videos fail to load.
Issue occurs both in my own code and in Kaltura examples:
http://player.kaltura.com/modules/DoubleClick/tests/DoubleClickSkipLocale.html

the following part in https://github.com/kaltura/mwEmbed/blob/master/modules/DoubleClick/resources/mw.DoubleClick.js

            try {
                this.adsLoaderLoaded = true;
                this.adsLoader.requestAds( adsRequest );
            } catch ( e ) {
                this.onAdError( e );
            }

reveals that it's a problem with missing slotId parameter.

In http://imasdk.googleapis.com/js/sdkloader/ima3.js file, which is unfortunately minified, we can spot a part which sets the slotId to a random integer:

            this.slotId=Math.floor(2147483646*Math.random())+1

Hence similar change added to requestAds method

            (...)
            adsRequest.linearAdSlotWidth = size.width;
            adsRequest.linearAdSlotHeight = size.height;

            adsRequest.nonLinearAdSlotWidth = size.width;
            adsRequest.nonLinearAdSlotHeight = size.height;

            adsRequest.slotId = Math.floor(2147483646 * Math.random()) + 1; // <-- HERE
            (...)

removes the problem totally although I didn't manage to figure out slotId meaning and significance.

[kaltura-hooks]

Hi @andrzejkrecicki,

Thank for you reporting an issue and helping improve Kaltura!

To get the fastest response time, and help the maintainers review and test your reported issues or suggestions, please ensure that your issue includes the following (please comment with more info if you have not included all this info in your original issue):

• Is the issue you're experiencing consistent and across platforms? or does it only happens on certain conditions?
  please provide as much details as possible.
• Which Kaltura deployment you're using: Kaltura SaaS, or self-hosted?
  If self hosted, are you using the RPM or deb install?
• Packages installed.
  When using RPM, paste the output for:

	# rpm -qa \"kaltura*\"

For deb based systems:

	# dpkg -l \"kaltura-*\"

• If running a self hosted ENV - provide the MySQL server version used
• If running a self hosted ENV - is this a single all in 1 server or a cluster?
• If running a self hosted ENV, while making the problematic request, run:

	# tail -f /opt/kaltura/log/*.log /opt/kaltura/log/batch/*.log | grep -A 1 -B 1 --color \"ERR:\|PHP\|trace\|CRIT\|\[error\]\"

and paste the output.

• When relevant, provide any screenshots or screen recordings showing the issue you're experiencing.

For general troubleshooting see:
https://github.com/kaltura/platform-install-packages/blob/Jupiter-10.13.0/doc/kaltura-packages-faq.md#troubleshooting-help

If you only have a general question rather than a bug report, please close this issue and post at:
http://forum.kaltura.org

Thank you in advance,

[slash851]

Experiencing the same error even on Kaltura test players:
http://player.kaltura.com/modules/DoubleClick/tests/DoubleClickAdEvents.qunit.html

Console logs:
content.js:4 [Deprecation] chrome.loadTimes() is deprecated, instead use standardized API: nextHopProtocol in Navigation Timing 2. https://www.chromestatus.com/features/5637885046816768.
(anonymous) @ content.js:4
content.js:5 [Deprecation] chrome.loadTimes() is deprecated, instead use standardized API: nextHopProtocol in Navigation Timing 2. https://www.chromestatus.com/features/5637885046816768.
(anonymous) @ content.js:5
kgit.html5video.org/branches/master/mwEmbedLoader.php:50 kWidget: Kaltura HTML5 Version: 2.68__ba045a91
jquery.min.js:4 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.
send @ jquery.min.js:4
mwEmbedLoader.php:31 allow attribute is overriding 'allowfullscreen'.

Event log for DoubleClick ads:
adErrorEvent event triggered
firstPlay event triggered
playerPlayed event triggered
playerPlayed event triggered

[andrzejkrecicki]

Looks like this commit 31138a5 fixed the issue.