-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML5 Player does not call VPAID 'resizeAd' on fullscreen #1585
Comments
should the ad disappear or just be resized / re-positioned? |
You just need to call resize ad with the correct adslot dimensions, positioning is handled by the ad, so no need to worry about that.
So on fullscreen, the player needs to call resizeAd, this is normally called with parameters like so: The width and height could be null on switching to fullscreen- it is the "fullscreen" string that is important- this allows us to hide the ad. On exit of fullscreen, you would then call the same function, but with the width and height of the player: |
Thanks! This will be added to the next player version (2.29) |
Good stuff, happy to test once you're ready- Just send over the PR as Michael suggested 👍 |
Hi, I have tested this and it seems to work fine in 2.29. However, I should have mentioned that the viewMode also needs to be passed on initAd- at the moment the 'normal' string is hardcoded, but it should pass in 'fullscreen' if the player is actually in fullscreen mode. Does this make sense?! Let me know if you'd like me to create a separate bug. |
This issue can be seen on the test page here:
coullwebsdk.herokuapp.com/minimal-test.php
However, because resizeAd is not called, we cannot hide the overlay.
From VPAID spec:
"Following a resize of the ad UI container, the player calls resizeAd to allow the ad to
scale or reposition itself within its display area."
Let me know if you need any further detail. Cheers :)
The text was updated successfully, but these errors were encountered: