Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML5 Player does not call VPAID 'resizeAd' on fullscreen #1585

Open
ocundale opened this issue Mar 5, 2015 · 6 comments
Open

HTML5 Player does not call VPAID 'resizeAd' on fullscreen #1585

ocundale opened this issue Mar 5, 2015 · 6 comments
Assignees

Comments

@ocundale
Copy link
Contributor

ocundale commented Mar 5, 2015

This issue can be seen on the test page here:
coullwebsdk.herokuapp.com/minimal-test.php

  • Wait for an overlay to appear, then go fullscreen- Expected functionality is that the overlay should disappear.
    However, because resizeAd is not called, we cannot hide the overlay.

From VPAID spec:
"Following a resize of the ad UI container, the player calls resizeAd to allow the ad to
scale or reposition itself within its display area."

Let me know if you need any further detail. Cheers :)

@mdale
Copy link

mdale commented Mar 5, 2015

should the ad disappear or just be resized / re-positioned?

@ocundale
Copy link
Contributor Author

ocundale commented Mar 5, 2015

You just need to call resize ad with the correct adslot dimensions, positioning is handled by the ad, so no need to worry about that.
You need to call the ad with the following params: resizeAd(width, height, viewMode)

  • width/height, if specified, should always match the maximum display area allotted for the ad
  • viewMode can be one of “normal”, “thumbnail”, or “fullscreen” to indicate the players current viewing mode.

So on fullscreen, the player needs to call resizeAd, this is normally called with parameters like so:
resizeAd(adslot.width, adslot.height, "fullscreen");

The width and height could be null on switching to fullscreen- it is the "fullscreen" string that is important- this allows us to hide the ad.

On exit of fullscreen, you would then call the same function, but with the width and height of the player:
resizeAd(480, 360, "normal");

@amirch1
Copy link
Contributor

amirch1 commented Mar 9, 2015

Thanks! This will be added to the next player version (2.29)

@mdale mdale assigned mdale and amirch1 and unassigned mdale Mar 9, 2015
@mdale
Copy link

mdale commented Mar 9, 2015

@amirch1 please let @ocundale know as soon as you have a pull request to try out.

@ocundale
Copy link
Contributor Author

ocundale commented Mar 9, 2015

Good stuff, happy to test once you're ready- Just send over the PR as Michael suggested 👍

@ocundale
Copy link
Contributor Author

Hi, I have tested this and it seems to work fine in 2.29. However, I should have mentioned that the viewMode also needs to be passed on initAd- at the moment the 'normal' string is hardcoded, but it should pass in 'fullscreen' if the player is actually in fullscreen mode. Does this make sense?! Let me know if you'd like me to create a separate bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants