Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save_factors parameter no longer functional in v2.0.2 #72

Open
chmnsk opened this issue Aug 12, 2023 · 0 comments
Open

save_factors parameter no longer functional in v2.0.2 #72

chmnsk opened this issue Aug 12, 2023 · 0 comments

Comments

@chmnsk
Copy link

chmnsk commented Aug 12, 2023

Bug

The save_factors parameter, which was functional in version v2.0.1, seems to have no effect in the recent v2.0.2 release.

To Reproduce

Steps to reproduce the behavior:

  1. Set up the environment with v2.0.2
  2. Set save_factors from als_option as True in
    def example1():
    log.set_log_level(log.DEBUG)
    als_option = ALSOption().get_default_option()
    als_option.validation = aux.Option({"topk": 10})
    data_option = MatrixMarketOptions().get_default_option()
    data_option.input.main = "../tests/ext/ml-100k/main"
    data_option.input.iid = "../tests/ext/ml-100k/iid"
    als = ALS(als_option, data_opt=data_option)
    als.initialize()
    als.train()
    print("MovieLens 100k metrics for validations\n%s" % json.dumps(als.get_validation_results(), indent=2))
    print("Similar movies to Star_Wars_(1977)")
    for rank, (movie_name, score) in enumerate(als.most_similar("49.Star_Wars_(1977)")):
    print(f"{rank + 1:02d}. {score:.3f} {movie_name}")
  3. Observe that the ALS model is not saved during training, whereas in v2.0.1 it was working as expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant