Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor maven profiles #90

Open
Haarolean opened this issue Feb 1, 2024 · 2 comments · May be fixed by #669
Open

Refactor maven profiles #90

Haarolean opened this issue Feb 1, 2024 · 2 comments · May be fixed by #669
Assignees
@KliminV
Labels
good first issue Up for grabs hacktoberfest Issues good for hacktoberfest goal scope/backend Related to backend changes scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/refactor Refactoring task

Comments

@Haarolean
Copy link
Member

Haarolean commented Feb 1, 2024 •
edited
Loading

Current issues:

  1. Some users need an API build without a frontend. There's a "skipuibuild" property for that. Doesn't seem optimal.
  2. Local build doesn't build frontend, which is usually required for a local run. Prod profile, on the other hand, builds a docker image, no way to easily disable this. Which is usually not required for a local run.
@Haarolean Haarolean added good first issue Up for grabs scope/backend Related to backend changes type/refactor Refactoring task labels Feb 1, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress labels Feb 1, 2024
@kapybro kapybro bot added status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 1, 2024
@Haarolean Haarolean added scope/infra CI, CD, dev. env, etc. and removed status/triage/manual Manual triage in progress labels Feb 1, 2024
@Haarolean Haarolean moved this to Intermediate in Up for grabs Feb 1, 2024
@Haarolean Haarolean removed their assignment Feb 1, 2024
@Haarolean Haarolean mentioned this issue Feb 6, 2024
Open
@Haarolean Haarolean moved this to Todo in Up for grabs Mar 16, 2024
@Haarolean Haarolean added the hacktoberfest Issues good for hacktoberfest goal label Oct 4, 2024
@KliminV
Copy link

KliminV commented Nov 21, 2024

@Haarolean i think i could do it, i wonder if you could give me permissions and assign it to me

@Haarolean
Copy link
Member Author

@Haarolean i think i could do it, i wonder if you could give me permissions and assign it to me

Thanks for the interest in contributing! You can raise a PR through a fork :)

@Haarolean Haarolean moved this from Todo to In Development in Up for grabs Nov 22, 2024
@KliminV KliminV linked a pull request Nov 22, 2024 that will close this issue
Open
12 tasks
KliminV added a commit to KliminV/kafka-ui that referenced this issue Nov 23, 2024
@KliminV
resolves kafbat#90
6927e2b 
Moved parent modules section into profiles
Added default profile to build all modules.
UI now only runs with local / prod profiles, but skipped by default
@Haarolean Haarolean moved this from In Development to In Review in Up for grabs Dec 2, 2024
@Haarolean Haarolean moved this from In Review to Changes requested in Up for grabs Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KliminV KliminV

Labels
good first issue Up for grabs hacktoberfest Issues good for hacktoberfest goal scope/backend Related to backend changes scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/refactor Refactoring task
Projects
Up for grabs
Status: Changes requested
Milestone
No milestone
2 participants
@Haarolean @KliminV