-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE: Fix HTTP 500 on protobuf Any type #696
base: main
Are you sure you want to change the base?
BE: Fix HTTP 500 on protobuf Any type #696
Conversation
hey team Why?
and the problem is in 'loadFilesWithLocations' and in
methods because in Windows paths use backslashes () but proto imports use forward slashes (/), so better would be create a ticket to normalize paths on both OS and be able to run project. I will create it and provide you a fix for it with a few additional test cases. |
…o-any' into issues/650-fix-err-500-with-proto-any
@DimaVilda yeah aware of it, been discussed here: #261. If you can fix them without altering production code, I'd be happy to accept such changes. |
@Haarolean , wdym without altering production code? There is incorrect backslashes processing in loadFilesWithLocations() so how can we fix it without touching it ? Or did I misunderstand your commet ? |
issue link:
Fixes #650
What changes did you make?
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)