Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infra: Do not run e2e reports task on forks #313

Open
Haarolean opened this issue Apr 22, 2024 · 3 comments · May be fixed by #443
Open

Infra: Do not run e2e reports task on forks #313

Haarolean opened this issue Apr 22, 2024 · 3 comments · May be fixed by #443
Assignees
@agungardiyanta
Labels
good first issue Up for grabs hacktoberfest Issues good for hacktoberfest goal scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt

Comments

@Haarolean
Copy link
Member

There's a repo name check but it doesn't seem to work, need to check for the fork signs in another way
https://github.com/kafbat/kafka-ui/actions/runs/8763118233/job/24051917042?pr=308
@Haarolean Haarolean added good first issue Up for grabs scope/infra CI, CD, dev. env, etc. type/chore Boring stuff, could be refactoring or tech debt labels Apr 22, 2024
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Apr 22, 2024
@Haarolean Haarolean moved this to Todo in Up for grabs Apr 22, 2024
@agungardiyanta
Copy link

Hi, may I take this issue?

@Haarolean
Copy link
Member Author

@agungardiyanta hey, sure. This line needs fixing

agungardiyanta added a commit to agungardiyanta/kafbat-ui that referenced this issue Jun 13, 2024
@agungardiyanta
fix Infra: Do not run e2e reports task on forks kafbat#313
12036bf
@agungardiyanta
Copy link

#443 this is my PR

agungardiyanta added a commit to agungardiyanta/kafbat-ui that referenced this issue Jun 13, 2024
@agungardiyanta
fix Infra: Do not run e2e reports task on forks kafbat#313
e267fa4
agungardiyanta added a commit to agungardiyanta/kafbat-ui that referenced this issue Jun 14, 2024
@agungardiyanta
fix Infra: Do not run e2e reports task on forks kafbat#313
d17bf01
@Haarolean Haarolean added the hacktoberfest Issues good for hacktoberfest goal label Oct 4, 2024
@Haarolean Haarolean moved this from Todo to In Review in Up for grabs Nov 3, 2024
@Haarolean Haarolean linked a pull request Dec 18, 2024 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agungardiyanta agungardiyanta

Labels
good first issue Up for grabs hacktoberfest Issues good for hacktoberfest goal scope/infra CI, CD, dev. env, etc. status/triage/completed Automatic triage completed type/chore Boring stuff, could be refactoring or tech debt
Projects
Up for grabs
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Infra: Do not run e2e reports task on forks #313 agungardiyanta/kafbat-ui
2 participants
@Haarolean @agungardiyanta