Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace checkstyle plugin #27

Open
Haarolean opened this issue Jan 23, 2024 · 2 comments
Open

Replace checkstyle plugin #27

Haarolean opened this issue Jan 23, 2024 · 2 comments
Labels
good first issue Up for grabs hacktoberfest Issues good for hacktoberfest goal scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt

Comments

@Haarolean
Copy link
Member

We require a viable solution to fix the checkstyle errors right in IDE. Currently you have to compile and visit each class present in logs.
This should work something like eslint/prettier with visual indication of invalidly formatted lines.

@Haarolean Haarolean added scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt labels Jan 23, 2024
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jan 23, 2024
@Haarolean Haarolean added good first issue Up for grabs and removed status/triage Issues pending maintainers triage labels Jan 24, 2024
@Haarolean Haarolean moved this to One shots in Up for grabs Jan 31, 2024
@Haarolean
Copy link
Member Author

https://github.com/palantir/palantir-java-format?tab=readme-ov-file

  • spotless plugin to enforce in CI

@Haarolean Haarolean added the hacktoberfest Issues good for hacktoberfest goal label Oct 4, 2024
@Haarolean
Copy link
Member Author

current checkstyle plugin doesn't care about formatting like this:

  public Mono<Void> deleteConsumerGroupOffset(KafkaCluster cluster,
                                            String groupId,
                                              String topicName) {
    return adminClientService.get(cluster)
        .flatMap(adminClient -> adminClient.deleteConsumerGroupOffsets(groupId, topicName));
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grabs hacktoberfest Issues good for hacktoberfest goal scope/backend Related to backend changes type/chore Boring stuff, could be refactoring or tech debt
Projects
Status: Todo
Development

No branches or pull requests

1 participant