Fix invite to NPWG slack #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readding NPWG slack invite mechanism. Signed-off-by: Kennelly, Martin <[email protected]>
Pull Request Test Coverage Report for Build 610452759
💛 - Coveralls |
|
LGTM, thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adding NPWG slack invite mechanism.
Signed-off-by: Kennelly, Martin [email protected]
I misunderstood slacks invite mechanism for non-Intel users. Non-Intel users require invite it seems. Re-adding invite mechanism. I attempted to change URL of invite mechanism but failed. Slack only grands auto invite rights to enterprise workspaces. See here outsideris/slack-invite-automation#146
Currently, the intel-corp.heroku.com app relies on legacy token mechanism to accomplish this. This will fail in the future when legacy tokens are deprecated. I think this should be discussed at NPWG level but in the mean time, I propose re-adding auto invite mechanism. Thanks @s1061123 for highlighting this!