Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ubuntu 23.10 for E2E tests #9755

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Mar 19, 2024

Proposed Changes

Avoids lavabit/robox#289 which is adding considerable time to our E2E CI

Master Branch This PR
image image
image image

Types of Changes

Verification

CI Still green

Testing

Its testing all the way down

Linked Issues

#9753

User-Facing Change


Further Comments

I will likely bump the tests to 24.04 when that is published next month. Being on a "non-lts" vagrant box is not a huge deal, but still, better to be on the version that a larger portion of our users will be running.

@dereknola dereknola requested a review from a team as a code owner March 19, 2024 17:30
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.39%. Comparing base (8aecc26) to head (d7f15f0).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9755       +/-   ##
===========================================
- Coverage   52.94%   28.39%   -24.55%     
===========================================
  Files         154      154               
  Lines       13601    13601               
===========================================
- Hits         7201     3862     -3339     
- Misses       5038     8964     +3926     
+ Partials     1362      775      -587     
Flag Coverage Δ
e2etests 8.56% <ø> (-40.89%) ⬇️
inttests 21.27% <ø> (-18.11%) ⬇️
unittests 16.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola merged commit c47c85e into k3s-io:master Mar 27, 2024
26 checks passed
@dereknola dereknola deleted the ubuntu2310 branch March 27, 2024 16:55
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 28, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 28, 2024
dereknola added a commit to dereknola/k3s that referenced this pull request Mar 28, 2024
dereknola added a commit that referenced this pull request Mar 31, 2024
dereknola added a commit that referenced this pull request Mar 31, 2024
dereknola added a commit that referenced this pull request Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants