-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to ubuntu 23.10 for E2E tests #9755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Nola <[email protected]>
brandond
approved these changes
Mar 19, 2024
manuelbuil
approved these changes
Mar 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9755 +/- ##
===========================================
- Coverage 52.94% 28.39% -24.55%
===========================================
Files 154 154
Lines 13601 13601
===========================================
- Hits 7201 3862 -3339
- Misses 5038 8964 +3926
+ Partials 1362 775 -587
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
to dereknola/k3s
that referenced
this pull request
Mar 28, 2024
Signed-off-by: Derek Nola <[email protected]>
This was referenced Mar 28, 2024
dereknola
added a commit
that referenced
this pull request
Mar 31, 2024
Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Mar 31, 2024
Signed-off-by: Derek Nola <[email protected]>
dereknola
added a commit
that referenced
this pull request
Mar 31, 2024
Signed-off-by: Derek Nola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Avoids lavabit/robox#289 which is adding considerable time to our E2E CI
Types of Changes
Verification
CI Still green
Testing
Its testing all the way down
Linked Issues
#9753
User-Facing Change
Further Comments
I will likely bump the tests to 24.04 when that is published next month. Being on a "non-lts" vagrant box is not a huge deal, but still, better to be on the version that a larger portion of our users will be running.