Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable E2E tests on GitHub Actions #9660

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Conversation

dereknola
Copy link
Member

Proposed Changes

  • Run several of the E2E tests in GitHub Actions on every PR
  • Convert the snapshotter smoke test into a full E2E btrfs test
  • Move from ubuntu 20.04 to 22.04 for all E2E tests
  • Don't require sudo vagrant everywhere for CI
  • Minor fixes in AfterSuite test cleanup, no longer have irrelevant failures around go coverage clogging up the logs.

Types of Changes

Testing

Verification

New CI passes in my forked PR dereknola#20

Testing

Its testing all the way down

Linked Issues

#9659

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner March 6, 2024 18:08
brandond
brandond previously approved these changes Mar 6, 2024
cwayne18
cwayne18 previously approved these changes Mar 6, 2024
galal-hussein
galal-hussein previously approved these changes Mar 6, 2024
Simplify node roles

Signed-off-by: Derek Nola <[email protected]>
@dereknola
Copy link
Member Author

Sorry some new tests were merged to master since I started working on all this so I had to add more to the Move to ubuntu 2204... commit

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.36%. Comparing base (6f331ea) to head (5898a7e).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #9660       +/-   ##
===========================================
- Coverage   51.52%   39.36%   -12.17%     
===========================================
  Files         154      151        -3     
  Lines       13595    13543       -52     
===========================================
- Hits         7005     5331     -1674     
- Misses       5253     7044     +1791     
+ Partials     1337     1168      -169     
Flag Coverage Δ
e2etests ?
inttests 39.36% <ø> (+0.03%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants