Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1beta2 e2e test coverage #123

Open
anmazzotti opened this issue May 23, 2024 · 3 comments
Open

Add v1beta2 e2e test coverage #123

anmazzotti opened this issue May 23, 2024 · 3 comments

Comments

@anmazzotti
Copy link
Contributor

The e2e tests should be expanded with v1beta2 resources.
The current tests can absolutely stay to test conversion, but they should be ported to v1beta2 in parallel.

Probably a good occasion to cover the CustomDefaulter for KThreesConfig and KThreesControlPlane resources as well.

@nasusoba
Copy link
Contributor

I have drafted a PR for using v1beta2 #124 , we also need to test clusterclass, we could also track clusterclass e2e testing here!

@nasusoba
Copy link
Contributor

I added an upgrade test for clusterclass in the drafted PR, but it seems that it does not trigger rollout, and the version for the machines remain old version. May need to do some investigation.

@nasusoba
Copy link
Contributor

The .Status.Version field is missing, results in rollout not triggered, fixed in #127 . Also MachinePools related test is not working, will disable them first. The upgrade could be successfully run after the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants