Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated WaitingForControlPlaneAvailableReason in v1beta2 #107

Open
anmazzotti opened this issue May 8, 2024 · 3 comments
Open

Remove deprecated WaitingForControlPlaneAvailableReason in v1beta2 #107

anmazzotti opened this issue May 8, 2024 · 3 comments

Comments

@anmazzotti
Copy link
Contributor

Pending merge of #88

The WaitingForControlPlaneAvailableReason should be removed in v1beta2
@mogliang
Copy link
Collaborator

mogliang commented May 8, 2024

Any reason why this reason should be removed?

@anmazzotti
Copy link
Contributor Author

Because the comment says so.
I did not investigate further, just trusted the comment and opened the issue so we don't forget.

@mogliang
Copy link
Collaborator

mogliang commented May 8, 2024

ok, i see. Since this is copied from capi, and capi still keep this condition, maybe we shall wait for capi to cleanup first

https://github.com/kubernetes-sigs/cluster-api/blob/main/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mogliang @anmazzotti