Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use automaxprocs? #137

Closed
sebhoss opened this issue Aug 16, 2024 · 3 comments · Fixed by #138
Closed

use automaxprocs? #137

sebhoss opened this issue Aug 16, 2024 · 3 comments · Fixed by #138

Comments

@sebhoss
Copy link
Contributor

sebhoss commented Aug 16, 2024

We are deploying sql_exporter into kubernetes and are currently setting GOMAXPROCS manually. If this package would use https://github.com/uber-go/automaxprocs we could remove that env var and simply set resource limits on the deployment.
@dewey
Copy link
Member

dewey commented Aug 16, 2024

Good point, would you be able to open a PR for that addition?

@sebhoss sebhoss mentioned this issue Aug 16, 2024
Merged
@sebhoss
Copy link
Contributor Author

sebhoss commented Aug 16, 2024

yep created #138

@dewey
Copy link
Member

dewey commented Aug 16, 2024

Perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add automaxprocs sebhoss/sql_exporter
2 participants
@sebhoss @dewey