Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rogue comma in invitation email subject #1124

Open
JohnAJ opened this issue Sep 9, 2022 · 2 comments
Open

Rogue comma in invitation email subject #1124

JohnAJ opened this issue Sep 9, 2022 · 2 comments
Labels

Comments

@JohnAJ
Copy link

JohnAJ commented Sep 9, 2022

When an invite is sent out, the subject line is: -

You've been Invited to Subscribe to, "{list-name-here}"

The comma after the "to" shouldn't be there?

@justingit justingit added the bug label Sep 9, 2022
@justingit
Copy link
Owner

That's how it's written in the template, so it should be there, in a very technical sense,

https://github.com/justingit/dada_mail_foundation_email_templates/blob/master/src/pages/invite_message.txt

If it needs to be in there, or should for whatever style of grammar being followed is certainly up for debate. If I was to follow I think what's being talked about here,

https://thecriticalreader.com/commas-names-titles/

I'd take it out.

@JohnAJ
Copy link
Author

JohnAJ commented Sep 9, 2022

Thanks,

I hadn't realised the subject is taken from the .txt version of the template, so an easy change for me :)

FWIW I agree, it shouldn't be there grammatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants