Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ESBuild platform node #1789

Closed
JeroenBoesten opened this issue Jun 2, 2024 · 2 comments
Closed

Custom ESBuild platform node #1789

JeroenBoesten opened this issue Jun 2, 2024 · 2 comments

Comments

@JeroenBoesten
Copy link

This is about the @angular-builders/custom-esbuild

Is your feature request related to a problem? Please describe.
I’m trying to use the esbuilder to build a angular / electron application as described in maximegris/angular-electron#810, the problem is when using node native modules like fs for example esbuild needs te platform to be set to node instead of browser (https://esbuild.github.io/getting-started/#bundling-for-node). As far as I can tell this is currently not possible yes change?

Describe the solution you'd like
I think it would make sense to be able to set the platform along with the other builder options in the angular.json

Describe alternatives you've considered
I did also search for alternative solutions and tried a lot of things without success, like changing the platform inside a plugin or adding the required node modules as externalDependencies.

@JeroenBoesten
Copy link
Author

The problem ended up to be somewhere else.

@just-jeb
Copy link
Owner

just-jeb commented Jun 4, 2024

Would be great if you shared the root cause and the solution in order to help others that encounter a similar issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants