Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ability to Mark PRs as API Changing #6

Open
blink1073 opened this issue Nov 17, 2021 · 1 comment
Open

Add Ability to Mark PRs as API Changing #6

blink1073 opened this issue Nov 17, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@blink1073
Copy link
Contributor

Problem

Right now we have to manually check for breaking PR changes in TypeScript.

Proposed Solution

Check for API Changes using API Extractor (compare current to the base reference) and add an api-change label as appropriate.

This is currently blocked by microsoft/rushstack#2070.
@blink1073 blink1073 added the enhancement New feature or request label Nov 17, 2021
@welcome
Copy link

welcome bot commented Nov 17, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blink1073