-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include @jupyterlab/builder in this package #16
Comments
After the move, should the package still be named Since the Python package seems to be named Looks like |
@cronan03 to test this, you need to
|
@fcollonval |
Hey @fcollonval, I’ve gone through the issue as thoroughly as I could and have a basic understanding of it. However, I still have a few questions that I believe are crucial for me to move forward. I transitioned builder from Could you kindly clarify the following:
I’d really appreciate your insights on this. It will help me overcome these roadblocks and push the work forward. |
@fcollonval |
Hey @Darshan808 The @jupyterlab/builder code contains the webpack configuration; see https://github.com/jupyterlab/jupyterlab/blob/main/builder/src/webpack.config.base.ts Regarding the interaction between the python code and the js code. As you found, it is python that executes the js code. You can see that more clearly looking at the extension building script: So about what will happen for extensions is the following: So I would say, the first step is to get the JavaScript code in. And ensure the python code is using the build-labextension file from jupyter-builder and not Jupyterlab. Then we will test how to modify extension build settings to use jupyter-builder. |
Do those comments make sense? |
Progress UpdateHere is the progress I've made so far:
I believe the next step would be to remove |
AlsoI have updated the extension's The build process is now using |
We should bring
@jupyterlab/builder
within this package and make it generic.For now the code lives there: https://github.com/jupyterlab/jupyterlab/tree/main/builder
The text was updated successfully, but these errors were encountered: